← Commit list

92fd791f31

Daniel Stenberg
Daniel Stenberg
2025-11-09
SUCCESS Duration: 139s

Subject

mqtt: reject overly big messages

Binary

No binary (build failed)

Architecture & Compiler Flags

Architecture: x86_64-linux-gnu Compiler: gcc (Ubuntu 11.4.0-1ubuntu1~22.04.3) 11.4.0

—

Build Log

(log yok)

Commit Diff GitHub →

lib/mqtt.c +4 -0
lib/mqtt.c+4 -0
@@ -582,6 +582,8 @@ fail:
return result;
}
+#define MAX_MQTT_MESSAGE_SIZE 0xFFFFFFF
+
static CURLcode mqtt_publish(struct Curl_easy *data)
{
CURLcode result;
@@ -611,6 +613,8 @@ static CURLcode mqtt_publish(struct Curl_easy *data)
remaininglength = payloadlen + 2 + topiclen;
encodelen = mqtt_encode_len(encodedbytes, remaininglength);
+ if(MAX_MQTT_MESSAGE_SIZE - remaininglength - 1 < encodelen)
+ return CURLE_TOO_LARGE;
/* add the control byte and the encoded remaining length */
pkt = malloc(remaininglength + 1 + encodelen);