← Commit list

96dbcf6921

Viktor Szakats
Viktor Szakats
2026-05-13
SUCCESS Duration: 359s

Subject

llist: constify struct pointers

Binary

No binary (build failed)

Architecture & Compiler Flags

Architecture: x86_64-linux-gnu Compiler: gcc (Ubuntu 11.4.0-1ubuntu1~22.04.3) 11.4.0

—

Build Log

(log yok)

Commit Diff GitHub →

lib/llist.c+11 -9
@@ -200,7 +200,7 @@ void Curl_llist_destroy(struct Curl_llist *list, void *user)
/* Curl_llist_head() returns the first 'struct Curl_llist_node *', which
might be NULL */
-struct Curl_llist_node *Curl_llist_head(struct Curl_llist *list)
+struct Curl_llist_node *Curl_llist_head(const struct Curl_llist *list)
{
DEBUGASSERT(list);
DEBUGASSERT(list->_init == LLISTINIT);
@@ -213,8 +213,8 @@ struct Curl_llist_node *Curl_llist_head(struct Curl_llist *list)
@unittest 1300
*/
-UNITTEST struct Curl_llist_node *llist_tail(struct Curl_llist *list);
-UNITTEST struct Curl_llist_node *llist_tail(struct Curl_llist *list)
+UNITTEST struct Curl_llist_node *llist_tail(const struct Curl_llist *list);
+UNITTEST struct Curl_llist_node *llist_tail(const struct Curl_llist *list)
{
DEBUGASSERT(list);
DEBUGASSERT(list->_init == LLISTINIT);
@@ -223,7 +223,7 @@ UNITTEST struct Curl_llist_node *llist_tail(struct Curl_llist *list)
#endif
/* Curl_llist_count() returns a size_t the number of nodes in the list */
-size_t Curl_llist_count(struct Curl_llist *list)
+size_t Curl_llist_count(const struct Curl_llist *list)
{
DEBUGASSERT(list);
DEBUGASSERT(list->_init == LLISTINIT);
@@ -231,7 +231,7 @@ size_t Curl_llist_count(struct Curl_llist *list)
}
/* Curl_node_elem() returns the custom data from a Curl_llist_node */
-void *Curl_node_elem(struct Curl_llist_node *n)
+void *Curl_node_elem(const struct Curl_llist_node *n)
{
DEBUGASSERT(n);
DEBUGASSERT(n->_init == NODEINIT);
@@ -240,7 +240,7 @@ void *Curl_node_elem(struct Curl_llist_node *n)
/* Curl_node_next() returns the next element in a list from a given
Curl_llist_node */
-struct Curl_llist_node *Curl_node_next(struct Curl_llist_node *n)
+struct Curl_llist_node *Curl_node_next(const struct Curl_llist_node *n)
{
DEBUGASSERT(n);
DEBUGASSERT(n->_init == NODEINIT);
@@ -253,8 +253,10 @@ struct Curl_llist_node *Curl_node_next(struct Curl_llist_node *n)
@unittest 1300
*/
-UNITTEST struct Curl_llist_node *llist_node_prev(struct Curl_llist_node *n);
-UNITTEST struct Curl_llist_node *llist_node_prev(struct Curl_llist_node *n)
+UNITTEST struct Curl_llist_node *llist_node_prev(
+ const struct Curl_llist_node *n);
+UNITTEST struct Curl_llist_node *llist_node_prev(
+ const struct Curl_llist_node *n)
{
DEBUGASSERT(n);
DEBUGASSERT(n->_init == NODEINIT);
@@ -262,7 +264,7 @@ UNITTEST struct Curl_llist_node *llist_node_prev(struct Curl_llist_node *n)
}
#endif
-struct Curl_llist *Curl_node_llist(struct Curl_llist_node *n)
+struct Curl_llist *Curl_node_llist(const struct Curl_llist_node *n)
{
DEBUGASSERT(n);
DEBUGASSERT(!n->_list || n->_init == NODEINIT);
lib/llist.h+5 -5
@@ -60,13 +60,13 @@ void Curl_llist_destroy(struct Curl_llist *list, void *user);
/* Curl_llist_head() returns the first 'struct Curl_llist_node *', which
might be NULL */
-struct Curl_llist_node *Curl_llist_head(struct Curl_llist *list);
+struct Curl_llist_node *Curl_llist_head(const struct Curl_llist *list);
/* Curl_llist_count() returns a size_t the number of nodes in the list */
-size_t Curl_llist_count(struct Curl_llist *list);
+size_t Curl_llist_count(const struct Curl_llist *list);
/* Curl_node_elem() returns the custom data from a Curl_llist_node */
-void *Curl_node_elem(struct Curl_llist_node *n);
+void *Curl_node_elem(const struct Curl_llist_node *n);
/* Remove the node from the list and return the custom data
* from a Curl_llist_node. Does NOT invoke a registered `dtor`. */
@@ -74,9 +74,9 @@ void *Curl_node_take_elem(struct Curl_llist_node *e);
/* Curl_node_next() returns the next element in a list from a given
Curl_llist_node */
-struct Curl_llist_node *Curl_node_next(struct Curl_llist_node *n);
+struct Curl_llist_node *Curl_node_next(const struct Curl_llist_node *n);
/* Curl_node_llist() return the list the node is in or NULL. */
-struct Curl_llist *Curl_node_llist(struct Curl_llist_node *n);
+struct Curl_llist *Curl_node_llist(const struct Curl_llist_node *n);
#endif /* HEADER_CURL_LLIST_H */