976a08985a
Stefan Eissing
2025-09-24
Subject
ares: fix leak in tracing
Binary
No binary (build failed)
Architecture & Compiler Flags
—
Build Log
(log yok)
Commit Diff GitHub →
lib/asyn-ares.c+5 -2
| @@ -747,8 +747,11 @@ struct Curl_addrinfo *Curl_async_getaddrinfo(struct Curl_easy *data, | |
| ares->result = CURLE_OK; | |
| #if ARES_VERSION >= 0x011800 /* >= v1.24.0 */ | |
| - | CURL_TRC_DNS(data, "asyn-ares: servers=%s", |
| - | ares_get_servers_csv(ares->channel)); |
| + | if(CURL_TRC_DNS_is_verbose(data)) { |
| + | char *csv = ares_get_servers_csv(ares->channel); |
| + | CURL_TRC_DNS(data, "asyn-ares: servers=%s", csv); |
| + | ares_free_string(csv); |
| + | } |
| #endif | |
| #ifdef HAVE_CARES_GETADDRINFO | |
lib/curl_trc.h+3 -1
| @@ -123,6 +123,8 @@ void Curl_trc_ws(struct Curl_easy *data, | |
| #define CURL_TRC_M_is_verbose(data) \ | |
| Curl_trc_ft_is_verbose(data, &Curl_trc_feat_multi) | |
| + | #define CURL_TRC_DNS_is_verbose(data) \ |
| + | Curl_trc_ft_is_verbose(data, &Curl_trc_feat_dns) |
| #if defined(CURL_HAVE_C99) && !defined(CURL_DISABLE_VERBOSE_STRINGS) | |
| #define infof(data, ...) \ | |
| @@ -141,7 +143,7 @@ void Curl_trc_ws(struct Curl_easy *data, | |
| do { if(Curl_trc_ft_is_verbose(data, &Curl_trc_feat_read)) \ | |
| Curl_trc_read(data, __VA_ARGS__); } while(0) | |
| #define CURL_TRC_DNS(data, ...) \ | |
| - | do { if(Curl_trc_ft_is_verbose(data, &Curl_trc_feat_dns)) \ |
| + | do { if(CURL_TRC_DNS_is_verbose(data)) \ |
| Curl_trc_dns(data, __VA_ARGS__); } while(0) | |
| #ifndef CURL_DISABLE_FTP | |