← Commit list

ec9cb618a0

Viktor Szakats
Viktor Szakats
2025-09-04
FAILED Duration: 181s

Subject

spacecheck: warn for 3+ empty lines in a row, fix fallouts

Binary

No binary (build failed)

Architecture & Compiler Flags

Architecture: x86_64-linux-gnu Compiler: gcc (Ubuntu 11.4.0-1ubuntu1~22.04.3) 11.4.0

—

Build Log

(log yok)

Commit Diff GitHub →

.github/scripts/spacecheck.pl +5 -0docs/examples/ephiperfifo.c +0 -4docs/examples/evhiperfifo.c +0 -4docs/examples/hiperfifo.c +0 -6lib/bufq.c +0 -1lib/curl_sha512_256.c +0 -1lib/ftp.c +0 -1lib/mime.c +0 -1lib/ws.c +0 -1packages/OS400/README.OS400 +0 -2tests/libtest/lib557.c +0 -1tests/runner.pm +0 -1tests/servers.pm +0 -2winbuild/MakefileBuild.vc +0 -1
.github/scripts/spacecheck.pl+5 -0
@@ -151,6 +151,11 @@ while(my $filename = <$git_ls_files>) {
push @err, "content: has multiple EOL at EOF";
}
+ if($content =~ /\n\n\n\n/ ||
+ $content =~ /\r\n\r\n\r\n\r\n/) {
+ push @err, "content: has 3 or more consecutive empty lines";
+ }
+
if($content =~ /([\x00-\x08\x0b\x0c\x0e-\x1f\x7f])/) {
push @err, "content: has binary contents";
}
docs/examples/ephiperfifo.c+0 -4
@@ -245,7 +245,6 @@ static void timer_cb(struct GlobalInfo *g, int revents)
}
-
/* Clean up the SockInfo structure */
static void remsock(struct SockInfo *f, struct GlobalInfo *g)
{
@@ -260,7 +259,6 @@ static void remsock(struct SockInfo *f, struct GlobalInfo *g)
}
-
/* Assign information to a SockInfo structure */
static void setsock(struct SockInfo *f, curl_socket_t s, CURL *e, int act,
struct GlobalInfo *g)
@@ -287,7 +285,6 @@ static void setsock(struct SockInfo *f, curl_socket_t s, CURL *e, int act,
}
-
/* Initialize a new SockInfo structure */
static void addsock(curl_socket_t s, CURL *easy, int action,
struct GlobalInfo *g)
@@ -328,7 +325,6 @@ static int sock_cb(CURL *e, curl_socket_t s, int what, void *cbp, void *sockp)
}
-
/* CURLOPT_WRITEFUNCTION */
static size_t write_cb(void *ptr, size_t size, size_t nmemb, void *data)
{
docs/examples/evhiperfifo.c+0 -4
@@ -165,7 +165,6 @@ static void mcode_or_die(const char *where, CURLMcode code)
}
-
/* Check for completed transfers, and remove their easy handles */
static void check_multi_info(struct GlobalInfo *g)
{
@@ -193,7 +192,6 @@ static void check_multi_info(struct GlobalInfo *g)
}
-
/* Called by libevent when we get action on a multi socket */
static void event_cb(EV_P_ struct ev_io *w, int revents)
{
@@ -243,7 +241,6 @@ static void remsock(struct SockInfo *f, struct GlobalInfo *g)
}
-
/* Assign information to a SockInfo structure */
static void setsock(struct SockInfo *f, curl_socket_t s, CURL *e, int act,
struct GlobalInfo *g)
@@ -265,7 +262,6 @@ static void setsock(struct SockInfo *f, curl_socket_t s, CURL *e, int act,
}
-
/* Initialize a new SockInfo structure */
static void addsock(curl_socket_t s, CURL *easy, int action,
struct GlobalInfo *g)
docs/examples/hiperfifo.c+0 -6
@@ -188,7 +188,6 @@ static void check_multi_info(struct GlobalInfo *g)
}
-
/* Called by libevent when we get action on a multi socket */
static void event_cb(int fd, short kind, void *userp)
{
@@ -212,7 +211,6 @@ static void event_cb(int fd, short kind, void *userp)
}
-
/* Called by libevent when our timeout expires */
static void timer_cb(int fd, short kind, void *userp)
{
@@ -228,7 +226,6 @@ static void timer_cb(int fd, short kind, void *userp)
}
-
/* Clean up the SockInfo structure */
static void remsock(struct SockInfo *f)
{
@@ -241,7 +238,6 @@ static void remsock(struct SockInfo *f)
}
-
/* Assign information to a SockInfo structure */
static void setsock(struct SockInfo *f, curl_socket_t s, CURL *e, int act,
struct GlobalInfo *g)
@@ -261,7 +257,6 @@ static void setsock(struct SockInfo *f, curl_socket_t s, CURL *e, int act,
}
-
/* Initialize a new SockInfo structure */
static void addsock(curl_socket_t s, CURL *easy, int action,
struct GlobalInfo *g)
@@ -302,7 +297,6 @@ static int sock_cb(CURL *e, curl_socket_t s, int what, void *cbp, void *sockp)
}
-
/* CURLOPT_WRITEFUNCTION */
static size_t write_cb(void *ptr, size_t size, size_t nmemb, void *data)
{
lib/bufq.c+0 -1
@@ -149,7 +149,6 @@ static void chunk_list_free(struct buf_chunk **anchor)
}
-
void Curl_bufcp_init(struct bufc_pool *pool,
size_t chunk_size, size_t spare_max)
{
lib/curl_sha512_256.c+0 -1
@@ -665,7 +665,6 @@ static CURLcode Curl_sha512_256_update(void *context,
}
-
/**
* Size of "length" insertion in bits.
* See FIPS PUB 180-4 section 5.1.2.
lib/ftp.c+0 -1
@@ -3774,7 +3774,6 @@ static CURLcode ftp_do_more(struct Curl_easy *data, int *completep)
}
-
/***********************************************************************
*
* ftp_perform()
lib/mime.c+0 -1
@@ -129,7 +129,6 @@ static const char aschex[] =
"\x30\x31\x32\x33\x34\x35\x36\x37\x38\x39\x41\x42\x43\x44\x45\x46";
-
#ifndef __VMS
#define filesize(name, stat_data) (stat_data.st_size)
#define fopen_read fopen
lib/ws.c+0 -1
@@ -882,7 +882,6 @@ static CURLcode ws_enc_write_payload(struct ws_encoder *enc,
}
-
struct cr_ws_ctx {
struct Curl_creader super;
BIT(read_eos); /* we read an EOS from the next reader */
packages/OS400/README.OS400+0 -2
@@ -256,7 +256,6 @@ _ TELNET
_ TFTP
-
Compiling on OS/400:
These instructions targets people who knows about OS/400, compiling, IFS and
@@ -328,7 +327,6 @@ _ Do not use original source include files unless you know what you are doing.
/curl/include/curl).
-
ILE/RPG support:
Since most of the ILE OS/400 programmers use ILE/RPG exclusively, a
tests/libtest/lib557.c+0 -1
@@ -1222,7 +1222,6 @@ static int test_width_precision(void)
}
-
static int test_weird_arguments(void)
{
int errors = 0;
tests/runner.pm+0 -1
@@ -1140,7 +1140,6 @@ sub singletest_postcheck {
}
-
###################################################################
# Get ready to run a single test case
sub runner_test_preprocess {
tests/servers.pm+0 -2
@@ -2244,8 +2244,6 @@ sub runnegtelnetserver {
}
-
-
#######################################################################
# Single shot http and gopher server responsiveness test. This should only
# be used to verify that a server present in %run hash is still functional
winbuild/MakefileBuild.vc+0 -1
@@ -422,7 +422,6 @@ CFGSET = true
!ENDIF
-
# CURL_XX macros are for the curl.exe command
!IF "$(DEBUG)"=="yes"