fdd6ba3580
alhudz
2026-06-18
Subject
cookie: check __Secure- and __Host- case sensitively when read from file
Binary
No binary (build failed)
Architecture & Compiler Flags
—
Build Log
(log yok)
Commit Diff GitHub →
lib/cookie.c+5 -3
| @@ -759,10 +759,12 @@ static CURLcode parse_netscape(struct Cookie *co, | |
| if(!co->name) | |
| return CURLE_OUT_OF_MEMORY; | |
| else { | |
| - | /* For Netscape file format cookies we check prefix on the name */ |
| - | if(curl_strnequal("__Secure-", co->name, 9)) |
| + | /* For Netscape file format cookies we check prefix on the name. |
| + | These prefixes are matched case sensitively, same as on the |
| + | header path and as the 6265bis document specifies. */ |
| + | if(!strncmp("__Secure-", co->name, 9)) |
| co->prefix_secure = TRUE; | |
| - | else if(curl_strnequal("__Host-", co->name, 7)) |
| + | else if(!strncmp("__Host-", co->name, 7)) |
| co->prefix_host = TRUE; | |
| } | |
| break; | |
tests/data/test2311+4 -2
| @@ -26,7 +26,7 @@ This server says moo | |
| http | |
| </server> | |
| <name> | |
| - | Cookie from file with control octet in value is rejected |
| + | Cookie from file: control octet rejected, prefixes matched case sensitively |
| </name> | |
| <command> | |
| http://example.fake/%TESTNUMBER -b %LOGDIR/injar%TESTNUMBER -x %HOSTIP:%HTTPPORT | |
| @@ -34,6 +34,8 @@ http://example.fake/%TESTNUMBER -b %LOGDIR/injar%TESTNUMBER -x %HOSTIP:%HTTPPORT | |
| <file name="%LOGDIR/injar%TESTNUMBER"> | |
| example.fake FALSE / FALSE 0 clean good | |
| example.fake FALSE / FALSE 0 bad %hex[ba%07d]hex% | |
| + | example.fake FALSE / FALSE 0 __secure-x yes |
| + | example.fake FALSE / FALSE 0 __Secure-y no |
| </file> | |
| <features> | |
| cookies | |
| @@ -49,7 +51,7 @@ Host: example.fake | |
| User-Agent: curl/%VERSION | |
| Accept: */* | |
| Proxy-Connection: Keep-Alive | |
| - | Cookie: clean=good |
| + | Cookie: __secure-x=yes; clean=good |
| </protocol> | |
| </verify> | |